[PM-12490] Extract OrganizationService.EnableAsync into commands #5321
+213
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Command for organization enabling
# Conflicts: # src/Billing/Services/Implementations/SubscriptionUpdatedHandler.cs
r-tome
force-pushed
the
ac/pm-12490/create-organization-enable-command
branch
from
d3b751a to
4c3c230
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5321 +/- ##
==========================================
+ Coverage 44.30% 44.33% +0.02%
==========================================
Files 1497 1498 +1
Lines 69207 69214 +7
Branches 6241 6241
==========================================
+ Hits 30661 30684 +23
+ Misses 37223 37207 -16
Partials 1323 1323 ☔ View full report in Codecov by Sentry. |
|
New Issues (14)Checkmarx found the following issues in this Pull Request
Fixed Issues (13)Great job! The following issues were fixed in this Pull Request
|
amorask-bitwarden
previously approved these changes
Jan 27, 2025
jonashendrickx
previously approved these changes
Jan 27, 2025
# Conflicts: # src/Core/AdminConsole/Services/IOrganizationService.cs # src/Core/AdminConsole/Services/Implementations/OrganizationService.cs # src/Core/OrganizationFeatures/OrganizationServiceCollectionExtensions.cs
r-tome
dismissed stale reviews from jonashendrickx and amorask-bitwarden
via
56d8794
|
I had to fix a few merge conflicts |
JimmyVo16
reviewed
Jan 28, 2025
.../Core.Test/AdminConsole/OrganizationFeatures/Organizations/OrganizationEnableCommandTests.cs
Show resolved
Hide resolved
JimmyVo16
requested changes
Jan 28, 2025
JimmyVo16
previously approved these changes
Jan 29, 2025
cturnbull-bitwarden
previously approved these changes
Feb 3, 2025
src/Core/AdminConsole/OrganizationFeatures/Organizations/OrganizationEnableCommand.cs
Outdated
Show resolved
Hide resolved
jonashendrickx
previously approved these changes
Feb 4, 2025
…d optional expiration
r-tome
dismissed stale reviews from jonashendrickx, cturnbull-bitwarden, and JimmyVo16
via
bf7871c
JimmyVo16
approved these changes
Feb 5, 2025
|
cturnbull-bitwarden
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12490
📔 Objective
Extract
OrganizationService.EnableAsynctoOrganizationEnableCommand.Add unit tests for OrganizationEnableCommand.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes